ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/nvme: Consolidate the code to create failover path in bdev_nvme_create()

Browse Source 
PCIe failover is not supported yet and it is not possible that the
controller is included in g_skipped_nvme_ctrlrs for failover cases.

We can consolidate the code to create failover path in bdev_nvme_create().

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ide456707a0b66a4b26eaf66392b9b53c3e659d9e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4387
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Shuhei Matsumoto 2020-09-24 10:58:58 +09:00 committed by Tomasz Zawadzki
parent cced29b595
commit dde21d3bbb
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
module/bdev/nvme/bdev_nvme.c
View File

@ -1947,6 +1947,9 @@ bdev_nvme_create(struct spdk_nvme_transport_id *trid,
free(ctx); free(ctx);
return rc; return rc;
} }
nvme_ctrlr_populate_namespaces_done(ctx);
return 0;
} }
if (trid->trtype == SPDK_NVME_TRANSPORT_PCIE) { if (trid->trtype == SPDK_NVME_TRANSPORT_PCIE) {
@ -1959,11 +1962,6 @@ bdev_nvme_create(struct spdk_nvme_transport_id *trid,
} }
} }
if (existing_ctrlr) {
nvme_ctrlr_populate_namespaces_done(ctx);
return 0;
}
spdk_nvme_ctrlr_get_default_ctrlr_opts(&ctx->opts, sizeof(ctx->opts)); spdk_nvme_ctrlr_get_default_ctrlr_opts(&ctx->opts, sizeof(ctx->opts));
ctx->opts.transport_retry_count = g_opts.retry_count; ctx->opts.transport_retry_count = g_opts.retry_count;