From dd9350c7e6327fd60b0758c9a8e3070a770fe02b Mon Sep 17 00:00:00 2001 From: Jacek Kalwas Date: Tue, 6 Apr 2021 08:59:49 -0400 Subject: [PATCH] build: fix missing pthread dependency for syslibs pc SYS_LIBS var is used to generate Lib.private section of spdk_syslibs.pc lack of pthread can result in linking issue when spdk's *.pc are used please note that usage of -lpthread and -pthread is not consisent within system wide pc files Signed-off-by: Jacek Kalwas Change-Id: I2dd327371d5621ea12f1e2f7abdfe6b7aa6602eb Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7253 Tested-by: SPDK CI Jenkins Reviewed-by: Maciej Szulik Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot --- mk/spdk.common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/spdk.common.mk b/mk/spdk.common.mk index d3bf5689b..b76d8d0e4 100644 --- a/mk/spdk.common.mk +++ b/mk/spdk.common.mk @@ -286,7 +286,7 @@ endif ifneq ($(OS),Windows) COMMON_CFLAGS += -pthread -LDFLAGS += -pthread +SYS_LIBS += -pthread endif CFLAGS += $(COMMON_CFLAGS) -Wno-pointer-sign -Wstrict-prototypes -Wold-style-definition -std=gnu99