From dd7b90fac98e9bb1d56e81f5d9c67c957555ed91 Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Wed, 27 Jun 2018 12:40:02 -0700 Subject: [PATCH] bdev: add null check to spdk_bdev_unregister: Newer versions of scan-build complain about cb_fn potentially being null in spdk_bdev_unregister. Change-Id: Ib5607234557f2104ee30398a620fa595389a33e9 Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/417064 Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker Tested-by: SPDK Automated Test System --- lib/bdev/bdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index 5a3c8e7fa..629b1d92b 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -2899,7 +2899,9 @@ spdk_bdev_unregister(struct spdk_bdev *bdev, spdk_bdev_unregister_cb cb_fn, void thread = spdk_get_thread(); if (!thread) { /* The user called this from a non-SPDK thread. */ - cb_fn(cb_arg, -ENOTSUP); + if (cb_fn != NULL) { + cb_fn(cb_arg, -ENOTSUP); + } return; }