From dd474d02868a5843e4bd522192864e134552dc07 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Tue, 19 Apr 2022 12:31:18 +0000 Subject: [PATCH] dpdkbuild: add DPDKBUILD_FLAGS variable Some environments (such as a VM on my M1-based MacBook Pro) report CPU with an Implementer+Part Number that DPDK doesn't explicitly support. In my case, it is Implementer ARM (0x41) but no part number (0x0). DPDK doesn't just default to a generic build in this case, it requires the user to specify -Dplatform=generic. We could try to plumb this into a configure option, but for now I'm fine in my dev environment to just specify this DPDKBUILD_FLAGS in my environment to work around it. Signed-off-by: Jim Harris Change-Id: I0465e3747de9b1ebacaf4ca53c2e6ccf36db1091 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12670 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Konrad Sztyber Reviewed-by: Dong Yi --- dpdkbuild/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dpdkbuild/Makefile b/dpdkbuild/Makefile index 946d52bd2..fc8111ae4 100644 --- a/dpdkbuild/Makefile +++ b/dpdkbuild/Makefile @@ -192,7 +192,7 @@ all: $(SPDK_ROOT_DIR)/dpdk/build-tmp $(SPDK_ROOT_DIR)/dpdk/build-tmp: $(SPDK_ROOT_DIR)/mk/cc.mk $(SPDK_ROOT_DIR)/include/spdk/config.h $(Q)rm -rf $(SPDK_ROOT_DIR)/dpdk/build $(SPDK_ROOT_DIR)/dpdk/build-tmp - $(Q)cd "$(SPDK_ROOT_DIR)/dpdk"; CC="$(SUB_CC)" meson --prefix="$(MESON_PREFIX)" --libdir lib -Dc_args="$(DPDK_CFLAGS)" -Dc_link_args="$(DPDK_LDFLAGS)" $(DPDK_OPTS) -Denable_drivers="$(shell echo $(DPDK_DRIVERS) | sed -E "s/ +/,/g")" -Ddisable_libs="$(shell echo $(DPDK_DISABLED_LIBS) | sed -E "s/ +/,/g")" build-tmp + $(Q)cd "$(SPDK_ROOT_DIR)/dpdk"; CC="$(SUB_CC)" meson --prefix="$(MESON_PREFIX)" --libdir lib -Dc_args="$(DPDK_CFLAGS)" -Dc_link_args="$(DPDK_LDFLAGS)" $(DPDK_OPTS) -Denable_drivers="$(shell echo $(DPDK_DRIVERS) | sed -E "s/ +/,/g")" -Ddisable_libs="$(shell echo $(DPDK_DISABLED_LIBS) | sed -E "s/ +/,/g")" $(DPDKBUILD_FLAGS) build-tmp $(Q)sed $(SED_INPLACE_FLAG) 's/#define RTE_EAL_PMD_PATH .*/#define RTE_EAL_PMD_PATH ""/g' $(SPDK_ROOT_DIR)/dpdk/build-tmp/rte_build_config.h $(Q) \ # TODO Meson build adds libbsd and/or libarchive dependency when it's available. This means any app will be \