ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rpc: Rename enable_tpoint_group to trace_enable_tpoint_group

Browse Source 
Change-Id: I1f9948ceacc615a9f0156c45de4c45cbe23ae9b0
Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469135
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Maciej Wawryk <maciejx.wawryk@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Pawel Kaminski 2019-09-23 09:11:10 -04:00 committed by Jim Harris
parent 378ad60b88
commit dd29bd7e8d
3 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/trace/trace_rpc.c
View File

@ -51,8 +51,8 @@ static const struct spdk_json_object_decoder rpc_tpoint_group_decoders[] = {
}; };
static void static void
spdk_rpc_enable_tpoint_group(struct spdk_jsonrpc_request *request, spdk_rpc_trace_enable_tpoint_group(struct spdk_jsonrpc_request *request,
const struct spdk_json_val *params) const struct spdk_json_val *params)
{ {
struct rpc_tpoint_group req = {}; struct rpc_tpoint_group req = {};
struct spdk_json_write_ctx *w; struct spdk_json_write_ctx *w;
@ -83,8 +83,9 @@ invalid:
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, "Invalid parameters"); spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, "Invalid parameters");
free_rpc_tpoint_group(&req); free_rpc_tpoint_group(&req);
} }
SPDK_RPC_REGISTER("enable_tpoint_group", spdk_rpc_enable_tpoint_group, SPDK_RPC_REGISTER("trace_enable_tpoint_group", spdk_rpc_trace_enable_tpoint_group,
SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME) SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(trace_enable_tpoint_group, enable_tpoint_group)
static void static void
spdk_rpc_disable_tpoint_group(struct spdk_jsonrpc_request *request, spdk_rpc_disable_tpoint_group(struct spdk_jsonrpc_request *request,

9
scripts/rpc.py
View File

@ -1147,14 +1147,15 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
p.set_defaults(func=get_scsi_devices) p.set_defaults(func=get_scsi_devices)
# trace # trace
def enable_tpoint_group(args): def trace_enable_tpoint_group(args):
rpc.trace.enable_tpoint_group(args.client, name=args.name) rpc.trace.trace_enable_tpoint_group(args.client, name=args.name)
p = subparsers.add_parser('enable_tpoint_group', help='enable trace on a specific tpoint group') p = subparsers.add_parser('trace_enable_tpoint_group', aliases=['enable_tpoint_group'],
help='enable trace on a specific tpoint group')
p.add_argument( p.add_argument(
'name', help="""trace group name we want to enable in tpoint_group_mask. 'name', help="""trace group name we want to enable in tpoint_group_mask.
(for example "bdev" for bdev trace group, "all" for all trace groups).""") (for example "bdev" for bdev trace group, "all" for all trace groups).""")
p.set_defaults(func=enable_tpoint_group) p.set_defaults(func=trace_enable_tpoint_group)
def disable_tpoint_group(args): def disable_tpoint_group(args):
rpc.trace.disable_tpoint_group(args.client, name=args.name) rpc.trace.disable_tpoint_group(args.client, name=args.name)

8
scripts/rpc/trace.py
View File

@ -1,11 +1,15 @@
def enable_tpoint_group(client, name): from .helpers import deprecated_alias
@deprecated_alias('enable_tpoint_group')
def trace_enable_tpoint_group(client, name):
"""Enable trace on a specific tpoint group. """Enable trace on a specific tpoint group.
Args: Args:
name: trace group name we want to enable in tpoint_group_mask. (for example "bdev"). name: trace group name we want to enable in tpoint_group_mask. (for example "bdev").
""" """
params = {'name': name} params = {'name': name}
return client.call('enable_tpoint_group', params) return client.call('trace_enable_tpoint_group', params)
def disable_tpoint_group(client, name): def disable_tpoint_group(client, name):