From dd06b35ed84c5ff1c9da7d53e40b2c6c154292c2 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Tue, 25 Apr 2023 09:29:45 +0200 Subject: [PATCH] bdev: remove handle_no_momem from push/seq cb The IOs are never completed with NOMEM from push/sequence callbacks and NOMEM IOs are already retried in internal callbacks, so there's no point in calling _bdev_io_handle_no_mem(). Signed-off-by: Konrad Sztyber Change-Id: Iecc2a41f2a394836f62d541e6235277f333f226b Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17765 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- lib/bdev/bdev.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index b197d939c..b342a785a 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -1550,10 +1550,6 @@ _bdev_io_complete_push_bounce_done(void *ctx, int rc) bdev_io_put_buf(bdev_io); /* Continue with IO completion flow */ - if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_INVALID))) { - return; - } - bdev_io_complete(bdev_io); } @@ -7092,10 +7088,6 @@ bdev_io_complete_sequence_cb(void *ctx, int status) bdev_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED; } - if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_INVALID))) { - return; - } - bdev_io_complete(bdev_io); }