From dafac529a683786157db399d71c62363a7aadc06 Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Thu, 8 Sep 2016 15:35:04 +0800 Subject: [PATCH] nvmf: fix bdev null pointer issue in spdk_nvmf_parse_subsystem Need to check bdev != NULL, otherwise there will be a segment fault later Change-Id: I8aa74e7716decc3166f9f2abbbb0c8ff73816f84 Signed-off-by: Ziye Yang --- app/nvmf_tgt/conf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/app/nvmf_tgt/conf.c b/app/nvmf_tgt/conf.c index 903bd927f..6920c8dab 100644 --- a/app/nvmf_tgt/conf.c +++ b/app/nvmf_tgt/conf.c @@ -507,7 +507,14 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp) nvmf_delete_subsystem(subsystem); return -1; } + bdev = spdk_bdev_get_by_name(namespace); + if (!bdev) { + SPDK_ERRLOG("bdev is NULL\n"); + nvmf_delete_subsystem(subsystem); + return -1; + } + if (spdk_nvmf_subsystem_add_ns(subsystem, bdev)) { nvmf_delete_subsystem(subsystem); return -1;