From d8a948ca1d984dc10083090991858e5e4936883d Mon Sep 17 00:00:00 2001 From: Vitaliy Mysak Date: Thu, 23 May 2019 23:37:30 +0000 Subject: [PATCH] ocf: RPC add WriteBack to allowed cache modes Make construct_ocf_bdev call accept 'wb' as allowed cache mode. Previusly user could only create OCF bdevs in WriteThrough or PassThrough modes. Signed-off-by: Vitaliy Mysak Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455628 (master) (cherry picked from commit 1e0e0ea1fc4e6615548e724f7e620d7c8c292e49) Change-Id: Ic2e1c8d2905cb51fc13c080aa7b7a4dfd7d9387f Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/457585 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Ben Walker --- doc/jsonrpc.md | 4 ++-- scripts/rpc.py | 2 +- scripts/rpc/bdev.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/jsonrpc.md b/doc/jsonrpc.md index 7ee6ce9f1..5b06b14e4 100644 --- a/doc/jsonrpc.md +++ b/doc/jsonrpc.md @@ -779,14 +779,14 @@ Example response: Construct new OCF bdev. Command accepts cache mode that is going to be used. -Currently, we support Write-Through and Pass-Through OCF cache modes. +Currently, we support Write-Through, Pass-Through and Write-Back OCF cache modes. ### Parameters Name | Optional | Type | Description ----------------------- | -------- | ----------- | ----------- name | Required | string | Bdev name to use -mode | Required | string | OCF cache mode ('wt' or 'pt') +mode | Required | string | OCF cache mode ('wb' or 'wt' or 'pt') cache_bdev_name | Required | string | Name of underlying cache bdev core_bdev_name | Required | string | Name of underlying core bdev diff --git a/scripts/rpc.py b/scripts/rpc.py index bd28ef48d..3bd8d99b2 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -183,7 +183,7 @@ if __name__ == "__main__": p = subparsers.add_parser('construct_ocf_bdev', help='Add an OCF block device') p.add_argument('name', help='Name of resulting OCF bdev') - p.add_argument('mode', help='OCF cache mode', choices=['wt', 'pt']) + p.add_argument('mode', help='OCF cache mode', choices=['wb', 'wt', 'pt']) p.add_argument('cache_bdev_name', help='Name of underlying cache bdev') p.add_argument('core_bdev_name', help='Name of unerlying core bdev') p.set_defaults(func=construct_ocf_bdev) diff --git a/scripts/rpc/bdev.py b/scripts/rpc/bdev.py index dcbf9b1ff..23536f803 100644 --- a/scripts/rpc/bdev.py +++ b/scripts/rpc/bdev.py @@ -73,7 +73,7 @@ def construct_ocf_bdev(client, name, mode, cache_bdev_name, core_bdev_name): Args: name: name of constructed OCF bdev - mode: OCF cache mode: {'wt', 'pt'} + mode: OCF cache mode: {'wb', 'wt', 'pt'} cache_bdev_name: name of underlying cache bdev core_bdev_name: name of underlying core bdev