From d87afb4cbd8b4dedf88805ba664f692a09986a18 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Wed, 19 Jan 2022 12:58:38 +0100 Subject: [PATCH] thread: remove io_device name from ioch tracepoints These tracepoints don't include this parameter in their definitions. This patch fixes the following assertion when the traces are enabled in the thread library: ``` _spdk_trace_record: Assertion `0 && "Unexpected number of tracepoint arguments"' failed ``` Signed-off-by: Konrad Sztyber Change-Id: I5159dbafd25c3150c90fa26c966dadb1fe239953 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11159 Reviewed-by: Tomasz Zawadzki Reviewed-by: Krzysztof Karas Reviewed-by: Aleksey Marchuk Tested-by: SPDK CI Jenkins --- lib/thread/thread.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/thread/thread.c b/lib/thread/thread.c index 216ea4ad0..cd109c8a7 100644 --- a/lib/thread/thread.c +++ b/lib/thread/thread.c @@ -2139,7 +2139,7 @@ spdk_get_io_channel(void *io_device) */ pthread_mutex_unlock(&g_devlist_mutex); spdk_trace_record(TRACE_THREAD_IOCH_GET, 0, 0, - (uint64_t)spdk_io_channel_get_ctx(ch), ch->ref, dev->name); + (uint64_t)spdk_io_channel_get_ctx(ch), ch->ref); return ch; } @@ -2174,7 +2174,7 @@ spdk_get_io_channel(void *io_device) return NULL; } - spdk_trace_record(TRACE_THREAD_IOCH_GET, 0, 0, (uint64_t)spdk_io_channel_get_ctx(ch), 1, dev->name); + spdk_trace_record(TRACE_THREAD_IOCH_GET, 0, 0, (uint64_t)spdk_io_channel_get_ctx(ch), 1); return ch; } @@ -2242,7 +2242,7 @@ spdk_put_io_channel(struct spdk_io_channel *ch) int rc __attribute__((unused)); spdk_trace_record(TRACE_THREAD_IOCH_PUT, 0, 0, - (uint64_t)spdk_io_channel_get_ctx(ch), ch->ref, ch->dev->name); + (uint64_t)spdk_io_channel_get_ctx(ch), ch->ref); thread = spdk_get_thread(); if (!thread) {