From d8343f94963be330077f6bff9eec9e2ac13c89f3 Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Mon, 20 Apr 2020 19:17:52 -0700 Subject: [PATCH] module/bdev_nvme: Fix some unreachable code. All of the error cases for spdk_nvme_transport_id_parse_trtype were covered earlier, so just make this an assert. fix kw warning 12653. Signed-off-by: Seth Howell Change-Id: If0eea934764b35d097887b98b0441ae5d7dd3e4f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1953 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Aleksey Marchuk --- module/bdev/nvme/bdev_nvme_rpc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/module/bdev/nvme/bdev_nvme_rpc.c b/module/bdev/nvme/bdev_nvme_rpc.c index 937c82108..f40622c4f 100644 --- a/module/bdev/nvme/bdev_nvme_rpc.c +++ b/module/bdev/nvme/bdev_nvme_rpc.c @@ -282,12 +282,7 @@ spdk_rpc_bdev_nvme_attach_controller(struct spdk_jsonrpc_request *request, /* Parse trtype */ rc = spdk_nvme_transport_id_parse_trtype(&trid.trtype, ctx->req.trtype); - if (rc < 0) { - SPDK_ERRLOG("Failed to parse trtype: %s\n", ctx->req.trtype); - spdk_jsonrpc_send_error_response_fmt(request, -EINVAL, "Failed to parse trtype: %s", - ctx->req.trtype); - goto cleanup; - } + assert(rc == 0); /* Parse traddr */ snprintf(trid.traddr, sizeof(trid.traddr), "%s", ctx->req.traddr);