From d7d7add855fbd0ebe12ea90a673a53376fe518f5 Mon Sep 17 00:00:00 2001 From: Tsuyoshi Uchida Date: Mon, 28 Nov 2016 09:58:26 -0800 Subject: [PATCH] nvme: fix ctrlr free issue (#74) spdk_nvme_probe frees ctrlr when nvme_ctrlr_process_init is failed. But ctrlr has already been freed while calling nvme_ctrlr_destruct. So spdk_nvme_probe doen't need to free ctrlr. --- lib/nvme/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/nvme/nvme.c b/lib/nvme/nvme.c index 767267065..57b7d2c14 100644 --- a/lib/nvme/nvme.c +++ b/lib/nvme/nvme.c @@ -318,7 +318,6 @@ _spdk_nvme_probe(const struct spdk_nvme_discover_info *info, void *cb_ctx, /* Controller failed to initialize. */ TAILQ_REMOVE(&g_spdk_nvme_driver->init_ctrlrs, ctrlr, tailq); nvme_ctrlr_destruct(ctrlr); - spdk_free(ctrlr); rc = -1; break; }