ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/accel: minor cleanup: remove extra stack variable in functions

Browse Source 
Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I8d2b286f5e21e0de32f67b3449e3fcf3904a2a9b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2401
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
paul luse 2020-05-12 17:15:51 -04:00 committed by Tomasz Zawadzki
parent 89495464b1
commit d7b0a892bc
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/accel/accel_engine.c
View File

@ -115,11 +115,10 @@ int
spdk_accel_submit_copy(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch, spdk_accel_submit_copy(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch,
void *dst, void *src, uint64_t nbytes, spdk_accel_completion_cb cb) void *dst, void *src, uint64_t nbytes, spdk_accel_completion_cb cb)
{ {
struct spdk_accel_task *req = accel_req;
struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch); struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
req->cb = cb; accel_req->cb = cb;
return accel_ch->engine->copy(req->offload_ctx, accel_ch->ch, dst, src, nbytes, return accel_ch->engine->copy(accel_req->offload_ctx, accel_ch->ch, dst, src, nbytes,
_accel_engine_done); _accel_engine_done);
} }
@ -129,7 +128,6 @@ spdk_accel_submit_dualcast(struct spdk_accel_task *accel_req, struct spdk_io_cha
void *dst1, void *dst2, void *src, uint64_t nbytes, void *dst1, void *dst2, void *src, uint64_t nbytes,
spdk_accel_completion_cb cb) spdk_accel_completion_cb cb)
{ {
struct spdk_accel_task *req = accel_req;
struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch); struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
if ((uintptr_t)dst1 & (ALIGN_4K - 1) || (uintptr_t)dst2 & (ALIGN_4K - 1)) { if ((uintptr_t)dst1 & (ALIGN_4K - 1) || (uintptr_t)dst2 & (ALIGN_4K - 1)) {
@ -137,8 +135,8 @@ spdk_accel_submit_dualcast(struct spdk_accel_task *accel_req, struct spdk_io_cha
return -EINVAL; return -EINVAL;
} }
req->cb = cb; accel_req->cb = cb;
return accel_ch->engine->dualcast(req->offload_ctx, accel_ch->ch, dst1, dst2, src, nbytes, return accel_ch->engine->dualcast(accel_req->offload_ctx, accel_ch->ch, dst1, dst2, src, nbytes,
_accel_engine_done); _accel_engine_done);
} }
@ -159,11 +157,10 @@ int
spdk_accel_submit_fill(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch, spdk_accel_submit_fill(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch,
void *dst, uint8_t fill, uint64_t nbytes, spdk_accel_completion_cb cb) void *dst, uint8_t fill, uint64_t nbytes, spdk_accel_completion_cb cb)
{ {
struct spdk_accel_task *req = accel_req;
struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch); struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
req->cb = cb; accel_req->cb = cb;
return accel_ch->engine->fill(req->offload_ctx, accel_ch->ch, dst, fill, nbytes, return accel_ch->engine->fill(accel_req->offload_ctx, accel_ch->ch, dst, fill, nbytes,
_accel_engine_done); _accel_engine_done);
} }
@ -172,13 +169,11 @@ int
spdk_accel_submit_crc32c(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch, spdk_accel_submit_crc32c(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch,
uint32_t *dst, void *src, uint32_t seed, uint64_t nbytes, spdk_accel_completion_cb cb) uint32_t *dst, void *src, uint32_t seed, uint64_t nbytes, spdk_accel_completion_cb cb)
{ {
struct spdk_accel_task *req = accel_req;
struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch); struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
req->cb = cb; accel_req->cb = cb;
return accel_ch->engine->crc32c(req->offload_ctx, accel_ch->ch, dst, src, return accel_ch->engine->crc32c(accel_req->offload_ctx, accel_ch->ch, dst, src,
seed, nbytes, seed, nbytes, _accel_engine_done);
_accel_engine_done);
} }