ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iscsi: Remove nested, duplicated, or unreferenced file inclusion

Browse Source 
When header files include other header files, it can be difficult
to read the chain of relationships. Hence remove obvious nested
header inclusion.

Remove obvious unreferenced header inclusion too.

Change-Id: I13b1c4e107da8c1a93fae4a0e3c3ee273887aab0
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/391363
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Shuhei Matsumoto 2017-12-13 09:49:12 +09:00 committed by Jim Harris
parent 06beb0249f
commit d777bfd148
5 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/iscsi/acceptor.c
View File

@ -35,7 +35,6 @@
#include "spdk/stdinc.h"
#include "spdk/env.h"
#include "spdk/event.h"
#include "spdk/io_channel.h"
#include "spdk/log.h"
#include "spdk/net.h"

3
lib/iscsi/conn.h
View File

@ -39,7 +39,6 @@
#include "iscsi/iscsi.h"
#include "spdk/queue.h"
#include "spdk/event.h"
/*
* MAX_CONNECTION_PARAMS: The numbers of the params in conn_param_table
@ -66,6 +65,8 @@
#define TRACE_ISCSI_CONN_ACTIVE SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x6)
#define TRACE_ISCSI_CONN_IDLE SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x7)
struct spdk_poller;
struct spdk_iscsi_conn {
int id;
int is_valid;

3
lib/iscsi/init_grp.c
View File

@ -35,13 +35,10 @@
#include "spdk/stdinc.h"
#include "spdk/conf.h"
#include "spdk/net.h"
#include "spdk_internal/log.h"
#include "iscsi/iscsi.h"
#include "iscsi/tgt_node.h"
#include "iscsi/conn.h"
#include "iscsi/init_grp.h"
static struct spdk_iscsi_init_grp *

2
lib/iscsi/portal_grp.c
View File

@ -36,11 +36,11 @@
#include "spdk/conf.h"
#include "spdk/net.h"
#include "spdk/event.h"
#include "spdk_internal/log.h"
#include "iscsi/iscsi.h"
#include "iscsi/tgt_node.h"
#include "iscsi/conn.h"
#include "iscsi/portal_grp.h"
#include "iscsi/acceptor.h"

4
lib/iscsi/tgt_node.c
View File

@ -34,10 +34,9 @@
#include "spdk/stdinc.h"
#include "spdk/env.h"
#include "spdk/event.h"
#include "spdk/conf.h"
#include "spdk/net.h"
#include "spdk/scsi.h"
#include "spdk_internal/log.h"
@ -46,7 +45,6 @@
#include "iscsi/tgt_node.h"
#include "iscsi/portal_grp.h"
#include "iscsi/init_grp.h"
#include "spdk/scsi.h"
#include "iscsi/task.h"
#define MAX_TMPBUF 1024