From d4bee12c97345c7772d73c3bbcb9648441c588af Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Wed, 27 Oct 2021 22:05:08 +0000 Subject: [PATCH] nvmf: change some ERRLOGs to DEBUGLOGs We generally shouldn't do ERRLOGs based on bad inputs from the host, so change some of these to DEBUGLOGs instead. Signed-off-by: Jim Harris Change-Id: Id42a8e51964e0238cd2841be8ac1d4ccaa1d150d Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10037 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Shuhei Matsumoto Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki --- lib/nvmf/ctrlr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index fe0c23e81..c285c7887 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -1259,7 +1259,7 @@ nvmf_property_get(struct spdk_nvmf_request *req) size = 8; break; default: - SPDK_ERRLOG("Invalid size value %d\n", cmd->attrib.size); + SPDK_DEBUGLOG(nvmf, "Invalid size value %d\n", cmd->attrib.size); response->status.sct = SPDK_NVME_SCT_COMMAND_SPECIFIC; response->status.sc = SPDK_NVMF_FABRIC_SC_INVALID_PARAM; return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; @@ -1317,7 +1317,7 @@ nvmf_property_set(struct spdk_nvmf_request *req) size = 8; break; default: - SPDK_ERRLOG("Invalid size value %d\n", cmd->attrib.size); + SPDK_DEBUGLOG(nvmf, "Invalid size value %d\n", cmd->attrib.size); response->status.sct = SPDK_NVME_SCT_COMMAND_SPECIFIC; response->status.sc = SPDK_NVMF_FABRIC_SC_INVALID_PARAM; return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; @@ -2299,7 +2299,7 @@ nvmf_ctrlr_get_log_page(struct spdk_nvmf_request *req) uint8_t lid; if (req->data == NULL) { - SPDK_ERRLOG("get log command with no buffer\n"); + SPDK_DEBUGLOG(nvmf, "get log command with no buffer\n"); response->status.sct = SPDK_NVME_SCT_GENERIC; response->status.sc = SPDK_NVME_SC_INVALID_FIELD; return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; @@ -2685,7 +2685,7 @@ nvmf_ctrlr_identify(struct spdk_nvmf_request *req) struct spdk_nvmf_subsystem *subsystem = ctrlr->subsys; if (req->data == NULL || req->length < 4096) { - SPDK_ERRLOG("identify command with invalid buffer\n"); + SPDK_DEBUGLOG(nvmf, "identify command with invalid buffer\n"); rsp->status.sct = SPDK_NVME_SCT_GENERIC; rsp->status.sc = SPDK_NVME_SC_INVALID_FIELD; return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;