From d172854aa767cf3effe62e58f63106105818a3cc Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Thu, 27 May 2021 23:30:34 +0800 Subject: [PATCH] configure: Fix the nasm version detection. I used the nasm with unstable version while compiling SPDK with ISA-L. And when running nasm -v, it shows: NASM version 2.16rc0 compiled on May 27 2021 So the version checking in the script is not correct, it will get "2.16rc0", but not "2.16". Then the version comparison will fail. This patch will fix such issue when users use an unstable nasm and it also works for the stable version. Change-Id: I950458f681642d7e1f5fc69acf2ced2e1342c9cf Signed-off-by: Ziye Yang Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8082 Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index a2d0c5a62..7438b91a6 100755 --- a/configure +++ b/configure @@ -166,7 +166,7 @@ fi #check nasm only on x86 if [[ $arch == x86_64* ]]; then - ver=$(nasm -v 2> /dev/null | awk '{print $3}') + ver=$(nasm -v 2> /dev/null | awk '{print $3}' | awk -Fr '{print $1}') if lt "$ver" 2.14; then # ISA-L, compression & crypto require NASM version 2.14 or newer. CONFIG[ISAL]=n