From d09be67d3fd7eda8267722d38e8d5c32bfcc65ce Mon Sep 17 00:00:00 2001
From: Seth Howell <seth.howell@intel.com>
Date: Thu, 23 Apr 2020 17:02:28 -0700
Subject: [PATCH] lib/iscsi: fix possible memory leak.

If we fail to allocate all of the params, we should free
the ones we did.

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: I0f0be6320b27211e3713d9b79b5a0b0ed103e7d2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2007
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
---
 lib/iscsi/iscsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/iscsi/iscsi.c b/lib/iscsi/iscsi.c
index 27a856e3b..a54617dc4 100644
--- a/lib/iscsi/iscsi.c
+++ b/lib/iscsi/iscsi.c
@@ -1342,6 +1342,7 @@ iscsi_op_login_store_incoming_params(struct spdk_iscsi_conn *conn,
 				&conn->partial_text_parameter);
 	if (rc < 0) {
 		SPDK_ERRLOG("iscsi_parse_params() failed\n");
+		iscsi_param_free(*params);
 		rsph->status_class = ISCSI_CLASS_INITIATOR_ERROR;
 		rsph->status_detail = ISCSI_LOGIN_INITIATOR_ERROR;
 		return SPDK_ISCSI_LOGIN_ERROR_PARAMETER;