From c3e0eb456be8f150d11effb15dc7eda1c1dbc442 Mon Sep 17 00:00:00 2001
From: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Date: Thu, 6 Feb 2020 13:13:44 +0100
Subject: [PATCH] nvme/rpc: fix memory leak when cmdbuf decode fails for
 bdev_nvme_send_cmd

Change-Id: I265f7b87d85c99f1fd709418b575c500a686e093
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/622
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
---
 module/bdev/nvme/nvme_rpc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/module/bdev/nvme/nvme_rpc.c b/module/bdev/nvme/nvme_rpc.c
index d38037a1d..b722f2282 100644
--- a/module/bdev/nvme/nvme_rpc.c
+++ b/module/bdev/nvme/nvme_rpc.c
@@ -280,10 +280,12 @@ rpc_decode_cmdbuf(const struct spdk_json_val *val, void *out)
 
 	rc = spdk_base64_urlsafe_decode(cmdbuf, &raw_len, text);
 	if (rc) {
+		free(cmdbuf);
 		goto out;
 	}
 	if (raw_len != sizeof(*cmdbuf)) {
 		rc = -EINVAL;
+		free(cmdbuf);
 		goto out;
 	}