From c2721e8ebe9de1d74e4b122dd6b772adc1330043 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Wed, 18 Jan 2017 10:58:38 -0700 Subject: [PATCH] test/log: verify that log facility is not NULL Make the static analyzer happy. Change-Id: I431b98af167d268f7e91c1f6d507c2c19d10ae25 Signed-off-by: Daniel Verkamp --- test/lib/log/Makefile | 1 + test/lib/log/log_ut.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/test/lib/log/Makefile b/test/lib/log/Makefile index 30b244540..bf131246c 100644 --- a/test/lib/log/Makefile +++ b/test/lib/log/Makefile @@ -37,6 +37,7 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk APP = log_ut C_SRCS := log_ut.c +CFLAGS += -I$(SPDK_ROOT_DIR)/test CFLAGS += -I$(SPDK_ROOT_DIR)/lib/log LIBS += $(SPDK_LIBS) -lcunit diff --git a/test/lib/log/log_ut.c b/test/lib/log/log_ut.c index 7fbaef66f..ed7aa971f 100644 --- a/test/lib/log/log_ut.c +++ b/test/lib/log/log_ut.c @@ -36,7 +36,7 @@ #include #include -#include "CUnit/Basic.h" +#include "spdk_cunit.h" #include "spdk/log.h" #include "log.c" @@ -56,9 +56,11 @@ log_test(void) spdk_g_log_facility = -1; buf = spdk_get_log_facility(); + SPDK_CU_ASSERT_FATAL(buf != NULL); CU_ASSERT_STRING_EQUAL(buf, "daemon"); spdk_g_log_facility = LOG_LOCAL7; buf = spdk_get_log_facility(); + SPDK_CU_ASSERT_FATAL(buf != NULL); CU_ASSERT_STRING_EQUAL(buf, "local7"); rc = spdk_set_log_priority("test");