ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/iscsi: fix use-after-free in bdev_iscsi_command_cb()

Browse Source 
Fixes issue #2946.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Ibd4d68ae6c639aede1fab56d04adf5583ef347f5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17210
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
This commit is contained in:
Jim Harris 2023-03-15 16:34:15 +00:00 committed by Konrad Sztyber
parent 0bd1ca9dc1
commit c161969df9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
module/bdev/iscsi/bdev_iscsi.c
View File

@ -269,8 +269,6 @@ bdev_iscsi_command_cb(struct iscsi_context *context, int status, void *_task, vo
iscsi_io->asc = (task->sense.ascq >> 8) & 0xFF; iscsi_io->asc = (task->sense.ascq >> 8) & 0xFF;
iscsi_io->ascq = task->sense.ascq & 0xFF; iscsi_io->ascq = task->sense.ascq & 0xFF;
scsi_free_scsi_task(task);
if (_bdev_iscsi_is_size_change(status, task)) { if (_bdev_iscsi_is_size_change(status, task)) {
bdev_iscsi_readcapacity16(context, iscsi_io->lun); bdev_iscsi_readcapacity16(context, iscsi_io->lun);
@ -285,6 +283,8 @@ bdev_iscsi_command_cb(struct iscsi_context *context, int status, void *_task, vo
} else { } else {
bdev_iscsi_io_complete(iscsi_io, SPDK_BDEV_IO_STATUS_SUCCESS); bdev_iscsi_io_complete(iscsi_io, SPDK_BDEV_IO_STATUS_SUCCESS);
} }
scsi_free_scsi_task(task);
} }
static int static int