From c0e069314512620c6dc797b6a77d5b207da4f231 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Fri, 9 Oct 2020 11:48:29 +0900 Subject: [PATCH] lib/bdev: spdk_bdev_open_ext() returns -ENODEV if bdev whose name matches is not found For example, for pass-through bdev modules, it is acceptable that bdev whose name matches is not found when creating a pass-through bdev. The next patch will replace spdk_bdev_open() by spdk_bdev_open_ext() for pass-through bdev module. spdk_bdev_open_ext() includes spdk_bdev_get_by_name(). Pass-through bdev module has to know if spdk_bdev_get_by_name() returned NULL in spdk_bdev_open_ext(). Hence change spdk_bdev_open_ext() to return -ENODEV if spdk_bdev_get_by_name() returned NULL. Signed-off-by: Shuhei Matsumoto Change-Id: I525a7118481586161bd0e8c07b96a887c0a04210 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4575 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Paul Luse Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build Bot --- lib/bdev/bdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index 065f473fd..3b7710e63 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -5709,7 +5709,7 @@ spdk_bdev_open_ext(const char *bdev_name, bool write, spdk_bdev_event_cb_t event if (bdev == NULL) { SPDK_ERRLOG("Failed to find bdev with name: %s\n", bdev_name); pthread_mutex_unlock(&g_bdev_mgr.mutex); - return -EINVAL; + return -ENODEV; } desc = calloc(1, sizeof(*desc));