From c071190e395c0fc4946a9a4e63bd2af068c3893a Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Fri, 30 Aug 2019 06:22:53 -0700 Subject: [PATCH] bdev/nvme: fix argument order for rpc aliases The new name comes first, the old name comes last. Eliminates warnings at app start time for set_bdev_nvme_options and set_bdev_nvme_hotplug aliases. Signed-off-by: Jim Harris Change-Id: Ia5ff3012e97bf59a6ecd9282dfc5cc0796ca7630 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466967 Reviewed-by: Ben Walker Reviewed-by: Broadcom SPDK FC-NVMe CI Reviewed-by: Changpeng Liu Tested-by: SPDK CI Jenkins --- module/bdev/nvme/bdev_nvme_rpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module/bdev/nvme/bdev_nvme_rpc.c b/module/bdev/nvme/bdev_nvme_rpc.c index 30819adb4..2a3ee9f27 100644 --- a/module/bdev/nvme/bdev_nvme_rpc.c +++ b/module/bdev/nvme/bdev_nvme_rpc.c @@ -109,7 +109,7 @@ spdk_rpc_bdev_nvme_set_options(struct spdk_jsonrpc_request *request, return; } SPDK_RPC_REGISTER("bdev_nvme_set_options", spdk_rpc_bdev_nvme_set_options, SPDK_RPC_STARTUP) -SPDK_RPC_REGISTER_ALIAS_DEPRECATED(set_bdev_nvme_options, bdev_nvme_set_options) +SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_nvme_set_options, set_bdev_nvme_options) struct rpc_bdev_nvme_hotplug { bool enabled; @@ -156,7 +156,7 @@ invalid: spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, spdk_strerror(-rc)); } SPDK_RPC_REGISTER("bdev_nvme_set_hotplug", spdk_rpc_bdev_nvme_set_hotplug, SPDK_RPC_RUNTIME) -SPDK_RPC_REGISTER_ALIAS_DEPRECATED(set_bdev_nvme_hotplug, bdev_nvme_set_hotplug) +SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_nvme_set_hotplug, set_bdev_nvme_hotplug) struct rpc_construct_nvme { char *name;