From beb468e9c72002c51c2b5ffb4bcd0abb1e46368b Mon Sep 17 00:00:00 2001 From: Jacek Kalwas Date: Wed, 22 Jul 2020 11:28:04 +0200 Subject: [PATCH] nvmf: fix cc.en and csts.rdy setting during shutdown CC.EN, CSTS.RDY should not be modified during shutdown. It doesn't make much sense (against nvme spec) and nvmf spec 1.1 doesn't mentioned it (4.6) either. Signed-off-by: Jacek Kalwas Change-Id: I7014b10b0217db61c3d380d5c0843808e54577cd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3477 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Changpeng Liu Reviewed-by: Seth Howell Reviewed-by: Aleksey Marchuk --- lib/nvmf/ctrlr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index b3187b16f..52f5ed8a0 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -811,8 +811,6 @@ nvmf_prop_set_cc(struct spdk_nvmf_ctrlr *ctrlr, uint32_t value) SPDK_DEBUGLOG(SPDK_LOG_NVMF, "Property Set CC Shutdown %u%ub!\n", cc.bits.shn >> 1, cc.bits.shn & 1); ctrlr->vcprop.cc.bits.shn = cc.bits.shn; - ctrlr->vcprop.cc.bits.en = 0; - ctrlr->vcprop.csts.bits.rdy = 0; spdk_for_each_channel(ctrlr->subsys->tgt, nvmf_ctrlr_disconnect_io_qpairs_on_pg, ctrlr,