From be0eef0a0d4a202ff1cbe4fb83e5f3bdecc0e376 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Thu, 12 Apr 2018 09:56:06 -0700 Subject: [PATCH] nvmf: check for missing NQN in conf parsing Avoid dereferencing a NULL pointer if NQN wasn't specified in the configuration file. Change-Id: Ie43111fce2c5fcf06bad00af10413a665dfbc45f Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/407484 Tested-by: SPDK Automated Test System Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- lib/event/subsystems/nvmf/conf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/event/subsystems/nvmf/conf.c b/lib/event/subsystems/nvmf/conf.c index fdb2381a5..dbdcd1dcf 100644 --- a/lib/event/subsystems/nvmf/conf.c +++ b/lib/event/subsystems/nvmf/conf.c @@ -151,6 +151,11 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp) int num_ns; nqn = spdk_conf_section_get_val(sp, "NQN"); + if (nqn == NULL) { + SPDK_ERRLOG("Subsystem missing NQN\n"); + return -1; + } + mode = spdk_conf_section_get_val(sp, "Mode"); lcore = spdk_conf_section_get_intval(sp, "Core"); num_ns = spdk_conf_section_get_intval(sp, "MaxNamespaces");