From be0eb272d806facee6ab442942d7f1fa7b66dcdb Mon Sep 17 00:00:00 2001 From: Maciej Szwed Date: Tue, 20 Nov 2018 15:37:25 +0100 Subject: [PATCH] tcp: Initialize mutex only if everything else succeeded Signed-off-by: Maciej Szwed Change-Id: Ib0bb6b40852ca4b49d46c2cbeb603b7a2ec4c46f Reviewed-on: https://review.gerrithub.io/434080 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto --- lib/nvmf/tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/nvmf/tcp.c b/lib/nvmf/tcp.c index f2ec03bbc..0a4dec79f 100644 --- a/lib/nvmf/tcp.c +++ b/lib/nvmf/tcp.c @@ -559,7 +559,6 @@ spdk_nvmf_tcp_create(struct spdk_nvmf_transport_opts *opts) return NULL; } - pthread_mutex_init(&ttransport->lock, NULL); TAILQ_INIT(&ttransport->ports); ttransport->transport.ops = &spdk_nvmf_transport_tcp; @@ -595,6 +594,8 @@ spdk_nvmf_tcp_create(struct spdk_nvmf_transport_opts *opts) return NULL; } + pthread_mutex_init(&ttransport->lock, NULL); + spdk_io_device_register(ttransport, spdk_nvmf_tcp_mgmt_channel_create, spdk_nvmf_tcp_mgmt_channel_destroy, sizeof(struct spdk_nvmf_tcp_mgmt_channel), "tcp_transport");