From bdbe33e663b141c1f71b2eef5b8b466e6737994c Mon Sep 17 00:00:00 2001 From: WANGHAILIANG Date: Tue, 3 Mar 2020 15:04:54 +0800 Subject: [PATCH] lib/iscsi: Add a assert for conn->sock In some cases, conn->sock will be lost, while conn pointer will still be. A runtime error will apperars: null pointer of type 'struct spdk_sock'. This only happens when ./configure with asan. So I add a sssert to display this error explicitly when it occurs. Change-Id: I7d012ac1a29a7fb0bce4815e0622582f23222a25 Signed-off-by: WANGHAILIANG Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1102 Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Darek Stojaczyk Reviewed-by: Ben Walker --- lib/iscsi/conn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/iscsi/conn.c b/lib/iscsi/conn.c index 37c49a33b..fd198785d 100644 --- a/lib/iscsi/conn.c +++ b/lib/iscsi/conn.c @@ -188,6 +188,7 @@ iscsi_poll_group_remove_conn(struct spdk_iscsi_poll_group *pg, struct spdk_iscsi { int rc; + assert(conn->sock != NULL); rc = spdk_sock_group_remove_sock(pg->sock_group, conn->sock); if (rc < 0) { SPDK_ERRLOG("Failed to remove sock=%p of conn=%p\n", conn->sock, conn);