From bd4aec1cd5be7031f024714d2ed17c49fd17ebab Mon Sep 17 00:00:00 2001
From: GangCao <gang.cao@intel.com>
Date: Mon, 12 Jul 2021 17:07:12 -0400
Subject: [PATCH] nvmf: add an assert for the obtained sgroup

Change-Id: Ie00137083143722e9df50fa5a8e4d37000dfe29c
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8739
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: <dongx.yi@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
---
 lib/nvmf/ctrlr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c
index 342126e0c..cebe7a6bc 100644
--- a/lib/nvmf/ctrlr.c
+++ b/lib/nvmf/ctrlr.c
@@ -811,6 +811,7 @@ retry_connect(void *arg)
 	int rc;
 
 	sgroup = nvmf_subsystem_pg_from_connect_cmd(req);
+	assert(sgroup != NULL);
 	sgroup->mgmt_io_outstanding++;
 	spdk_poller_unregister(&req->poller);
 	rc = nvmf_ctrlr_cmd_connect(req);
@@ -861,6 +862,7 @@ nvmf_ctrlr_cmd_connect(struct spdk_nvmf_request *req)
 		 * subsystem waiting for this command to complete before unpausing.
 		 */
 		sgroup = nvmf_subsystem_pg_from_connect_cmd(req);
+		assert(sgroup != NULL);
 		sgroup->mgmt_io_outstanding--;
 		SPDK_DEBUGLOG(nvmf, "Subsystem '%s' is not ready for connect, retrying...\n", subsystem->subnqn);
 		req->poller = SPDK_POLLER_REGISTER(retry_connect, req, 100);