ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

module/crypto: add UT coverage for error path in poller

Browse Source 
Add coverage to the path where we dequeue multiple ops for a
bdev_io and one of them has failed. Confirm that the bdev_io
gets failed.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Ie864b63819f506da43fdcad960c26a48a01196c7
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/472417
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
paul luse 2019-10-25 17:50:07 +00:00 committed by Tomasz Zawadzki
parent dc8788d150
commit bcfb51b124
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/unit/lib/bdev/crypto.c/crypto_ut.c
View File

@ -88,8 +88,7 @@ mock_rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,
CU_ASSERT(nb_ops > 0);
for (i = 0; i < g_dequeue_mock; i++) {
*ops = g_test_crypto_ops[i];
(*ops)->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
*ops++ = g_test_crypto_ops[i];
}
return g_dequeue_mock;
@ -900,7 +899,7 @@ static void
test_poller(void)
{
int rc;
struct rte_mbuf *src_mbufs[1];
struct rte_mbuf *src_mbufs[2];
struct vbdev_crypto_op *op_to_resubmit;
/* test regular 1 op to dequeue and complete */
@ -931,6 +930,23 @@ test_poller(void)
g_resubmit_test = false;
CU_ASSERT(rc == 0);
CU_ASSERT(TAILQ_EMPTY(&g_crypto_ch->queued_cry_ops) == true);
/* 2 to dequeue but 2nd one failed */
g_dequeue_mock = g_enqueue_mock = 2;
g_io_ctx->cryop_cnt_remaining = 2;
spdk_mempool_get_bulk(g_mbuf_mp, (void **)&src_mbufs[0], 2);
g_test_crypto_ops[0]->sym->m_src = src_mbufs[0];
g_test_crypto_ops[0]->sym->m_src->userdata = g_bdev_io;
g_test_crypto_ops[0]->sym->m_dst = NULL;
g_test_crypto_ops[0]->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
g_test_crypto_ops[1]->sym->m_src = src_mbufs[1];
g_test_crypto_ops[1]->sym->m_src->userdata = g_bdev_io;
g_test_crypto_ops[1]->sym->m_dst = NULL;
g_test_crypto_ops[1]->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;
g_bdev_io->internal.status = SPDK_BDEV_IO_STATUS_SUCCESS;
rc = crypto_dev_poller(g_crypto_ch);
CU_ASSERT(g_bdev_io->internal.status == SPDK_BDEV_IO_STATUS_FAILED);
CU_ASSERT(rc == 2);
}
int