ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: convert is_resetting to bool

Browse Source 
It was previously uint32_t because it was accessed with special
uint32_t-only atomic read/write helper functions, but that was replaced
with normal variable accesses protected by a mutex.

Change-Id: I304a7ef8c723cb33fd08110b697f848823a163e7
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2015-11-02 17:51:32 -07:00
parent 4d7b500ade
commit bc185fe7dc
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/nvme/nvme_ctrlr.c
View File

@ -308,7 +308,7 @@ nvme_ctrlr_reset(struct nvme_controller *ctrlr)
return 0; return 0;
} }
ctrlr->is_resetting = 1; ctrlr->is_resetting = true;
nvme_printf(ctrlr, "resetting controller\n"); nvme_printf(ctrlr, "resetting controller\n");
/* nvme_ctrlr_start() issues a reset as its first step */ /* nvme_ctrlr_start() issues a reset as its first step */
@ -317,7 +317,7 @@ nvme_ctrlr_reset(struct nvme_controller *ctrlr)
nvme_ctrlr_fail(ctrlr); nvme_ctrlr_fail(ctrlr);
} }
ctrlr->is_resetting = 0; ctrlr->is_resetting = false;
nvme_mutex_unlock(&ctrlr->ctrlr_lock); nvme_mutex_unlock(&ctrlr->ctrlr_lock);
@ -678,7 +678,7 @@ nvme_ctrlr_construct(struct nvme_controller *ctrlr, void *devhandle)
if (rc) if (rc)
return rc; return rc;
ctrlr->is_resetting = 0; ctrlr->is_resetting = false;
ctrlr->is_failed = false; ctrlr->is_failed = false;
nvme_mutex_init_recursive(&ctrlr->ctrlr_lock); nvme_mutex_init_recursive(&ctrlr->ctrlr_lock);

2
lib/nvme/nvme_internal.h
View File

@ -233,7 +233,7 @@ struct nvme_controller {
/** I/O queue pairs */ /** I/O queue pairs */
struct nvme_qpair *ioq; struct nvme_qpair *ioq;
uint32_t is_resetting; bool is_resetting;
uint32_t num_ns; uint32_t num_ns;