From ba5329d3e4a03bd10c493460b7a78ad3624e8f5d Mon Sep 17 00:00:00 2001 From: Karol Latecki Date: Fri, 21 Feb 2020 10:47:29 +0100 Subject: [PATCH] test/nvme: do not skip tests if nvme-cli is unavailable We do not want to skip tests, especially that the 'if' statement is inside the test script. So even though the test wasn't actually ran it still is reported as executed because "spdk_nvme_cli.sh" returned with rc=0. Signed-off-by: Karol Latecki Change-Id: I89c553aebcc1346f8f584dd86eeae1ca146e7340 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/980 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Tomasz Zawadzki Reviewed-by: Michal Berger --- test/nvme/spdk_nvme_cli.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/nvme/spdk_nvme_cli.sh b/test/nvme/spdk_nvme_cli.sh index ccb179c09..c0d7392be 100755 --- a/test/nvme/spdk_nvme_cli.sh +++ b/test/nvme/spdk_nvme_cli.sh @@ -14,7 +14,7 @@ spdk_nvme_cli="${DEPENDENCY_DIR}/nvme-cli" if [ ! -d $spdk_nvme_cli ]; then echo "nvme-cli repository not found at $spdk_nvme_cli; skipping tests." - exit 0 + exit 1 fi if [ $(uname) = Linux ]; then