From ba3db1d2ea2d563d73d7618c1c0378789a4db39e Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Fri, 26 Jul 2019 06:55:07 +0200 Subject: [PATCH] ut/nvme: silence scan-build warnings about null dereference nvme_ut.c:755:2: warning: Dereference of null pointer TAILQ_REMOVE(&probe_ctx.init_ctrlrs, dummy, tailq); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /var/jenkins/workspace/Other/unittest_autotests/spdk/include/spdk/queue.h:62:6: note: expanded from macro 'TAILQ_REMOVE' if (((elm)->field.tqe_next) != NULL) Change-Id: I8ee6a476f2658668304e182a6c8cff4d79ae2f40 Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463257 Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Paul Luse Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- test/unit/lib/nvme/nvme.c/nvme_ut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/lib/nvme/nvme.c/nvme_ut.c b/test/unit/lib/nvme/nvme.c/nvme_ut.c index 2468b3cdc..21414c58b 100644 --- a/test/unit/lib/nvme/nvme.c/nvme_ut.c +++ b/test/unit/lib/nvme/nvme.c/nvme_ut.c @@ -751,6 +751,7 @@ test_nvme_ctrlr_probe(void) rc = nvme_ctrlr_probe(&trid, &probe_ctx, devhandle); CU_ASSERT(rc == 0); dummy = TAILQ_FIRST(&probe_ctx.init_ctrlrs); + SPDK_CU_ASSERT_FATAL(dummy != NULL); CU_ASSERT(dummy == ut_nvme_transport_ctrlr_construct); TAILQ_REMOVE(&probe_ctx.init_ctrlrs, dummy, tailq); MOCK_CLEAR_P(nvme_transport_ctrlr_construct);