ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf: remove nvmf_property_set() shutdown flag

Browse Source 
Property Set of CC.SHN is not supposed to terminate the session - remove
the commented-out code that was attempting to do this.

Change-Id: I1db230df9be549764287a8fd45ccdebea1d22a8b
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2016-07-18 09:06:52 -07:00
parent 8a2395d0e6
commit b9a67e983a
3 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/nvmf/request.c
View File

@ -371,18 +371,10 @@ static bool
nvmf_process_property_set(struct spdk_nvmf_request *req)
{
struct spdk_nvmf_fabric_prop_set_cmd *cmd;
bool shutdown = false;
cmd = &req->cmd->prop_set_cmd;
nvmf_property_set(req->conn->sess, cmd, &req->rsp->nvme_cpl, &shutdown);
/* TODO: This is not right. It should shut down the whole session.
if (shutdown == true) {
SPDK_TRACELOG(SPDK_TRACE_DEBUG, "Call to set properties has indicated shutdown\n");
conn->state = CONN_STATE_FABRIC_DISCONNECT;
}
*/
nvmf_property_set(req->conn->sess, cmd, &req->rsp->nvme_cpl);
return true;
}

3
lib/nvmf/session.c
View File

@ -427,8 +427,7 @@ nvmf_property_get(struct nvmf_session *session,
void
nvmf_property_set(struct nvmf_session *session,
struct spdk_nvmf_fabric_prop_set_cmd *cmd,
struct spdk_nvme_cpl *response,
bool *shutdown)
struct spdk_nvme_cpl *response)
{
const struct nvmf_prop *prop;
uint64_t value;

3
lib/nvmf/session.h
View File

@ -100,8 +100,7 @@ nvmf_property_get(struct nvmf_session *session,
void
nvmf_property_set(struct nvmf_session *session,
struct spdk_nvmf_fabric_prop_set_cmd *cmd,
struct spdk_nvme_cpl *rsp,
bool *shutdown);
struct spdk_nvme_cpl *rsp);
int spdk_nvmf_session_poll(struct nvmf_session *session);