ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/setup.sh: Fix. Variable virtio_names used as array contains empty first element.

Browse Source 
It fixes change 474989.

"for blkname in $blknames; do"
was changed to
"for blkname in "${blknames[@]}"; do"
if blknames=" vda" then first blkname="" and
linux_bind_driver is called for vda although it has active mountpoint

Change-Id: I16d4379db274faa5703230072cfcf8d18a8ef5e6
Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/476061
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Pawel Kaminski 2019-11-28 06:33:49 -05:00 committed by Tomasz Zawadzki
parent d453c9400e
commit b98f5c2429
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/setup.sh
View File

@ -159,15 +159,15 @@ function get_nvme_name_from_bdf {
function get_virtio_names_from_bdf { function get_virtio_names_from_bdf {
blk_devs=$(lsblk --nodeps --output NAME) blk_devs=$(lsblk --nodeps --output NAME)
virtio_names='' virtio_names=()
for dev in $blk_devs; do for dev in $blk_devs; do
if readlink "/sys/block/$dev" | grep -q "$1"; then if readlink "/sys/block/$dev" | grep -q "$1"; then
virtio_names="$virtio_names $dev" virtio_names+=("$dev")
fi fi
done done
eval "$2='$virtio_names'" eval "$2=( " "${virtio_names[@]}" " )"
} }
function configure_linux_pci { function configure_linux_pci {