ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/iscsi: fix one inappropriate assertion

Browse Source 
Port scanning causes iscsi_tgt assertion failure, try using
'nmap -sV ${host} -p ${port}' to reproduce the assertion failure
'ahs_len <= ISCSI_AHS_LEN', fix this issue.

Signed-off-by: Sochin Jiang <jiangxiaoqing.sochin@bytedance.com>
Change-Id: I3ada9f0faf746792264e0ce74eb11eebba9d9432
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4585
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Sochin Jiang 2020-10-10 18:57:16 +08:00 committed by Tomasz Zawadzki
parent 8d081e74c1
commit b866d5192f
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/iscsi/iscsi.c
View File

@ -4597,7 +4597,12 @@ iscsi_read_pdu(struct spdk_iscsi_conn *conn)
/* AHS */
ahs_len = pdu->bhs.total_ahs_len * 4;
assert(ahs_len <= ISCSI_AHS_LEN);
if (ahs_len > ISCSI_AHS_LEN) {
SPDK_DEBUGLOG(SPDK_LOG_ISCSI, "pdu ahs length %d is invalid\n", ahs_len);
conn->pdu_recv_state = ISCSI_PDU_RECV_STATE_ERROR;
break;
}
if (pdu->ahs_valid_bytes < ahs_len) {
rc = iscsi_conn_read_data(conn,
ahs_len - pdu->ahs_valid_bytes,