From b5497ac2134020cd03bd186704c9349df5375f5a Mon Sep 17 00:00:00 2001 From: GangCao Date: Tue, 31 Jan 2023 00:50:44 -0500 Subject: [PATCH] lib/accel: correct the optional parameter of RPC commands The relatd RPC commands are: 1. accel_crypto_keys_get (parameter is optional) 2. accel_crypto_key_destory (parameter is required) Change-Id: I580c6e32bddf8242d0c26be988e2c151f47f2548 Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16627 Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki --- lib/accel/accel_rpc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/accel/accel_rpc.c b/lib/accel/accel_rpc.c index 4db1be732..a5fd3252d 100644 --- a/lib/accel/accel_rpc.c +++ b/lib/accel/accel_rpc.c @@ -230,7 +230,7 @@ struct rpc_accel_crypto_keys_get_ctx { }; static const struct spdk_json_object_decoder rpc_accel_crypto_keys_get_decoders[] = { - {"key_name", offsetof(struct rpc_accel_crypto_keys_get_ctx, key_name), spdk_json_decode_string}, + {"key_name", offsetof(struct rpc_accel_crypto_keys_get_ctx, key_name), spdk_json_decode_string, true}, }; static void @@ -274,7 +274,7 @@ rpc_accel_crypto_keys_get(struct spdk_jsonrpc_request *request, SPDK_RPC_REGISTER("accel_crypto_keys_get", rpc_accel_crypto_keys_get, SPDK_RPC_RUNTIME) static const struct spdk_json_object_decoder rpc_accel_crypto_key_destroy_decoders[] = { - {"key_name", offsetof(struct rpc_accel_crypto_keys_get_ctx, key_name), spdk_json_decode_string, true}, + {"key_name", offsetof(struct rpc_accel_crypto_keys_get_ctx, key_name), spdk_json_decode_string}, }; static void @@ -285,9 +285,9 @@ rpc_accel_crypto_key_destroy(struct spdk_jsonrpc_request *request, struct spdk_accel_crypto_key *key = NULL; int rc; - if (params && spdk_json_decode_object(params, rpc_accel_crypto_key_destroy_decoders, - SPDK_COUNTOF(rpc_accel_crypto_key_destroy_decoders), - &req)) { + if (spdk_json_decode_object(params, rpc_accel_crypto_key_destroy_decoders, + SPDK_COUNTOF(rpc_accel_crypto_key_destroy_decoders), + &req)) { spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_PARSE_ERROR, "spdk_json_decode_object failed"); free(req.key_name);