From b48596efbcaeba3d38a388d43e553ca80a3f4fcc Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Tue, 5 Jan 2021 19:25:17 +0800 Subject: [PATCH] lib/nbd: Remove errno != EWOULDBLOCK in nbd_socket_rw In this commit (a1d4a714b25aa26068e3e3e686dfd2c1283164df), we refactor the code but introduce the new error comparison. And it causes the hang issue in some cases for RPC, so remove it. Change-Id: I4da802dff24b7efc27dd25a05739f1def37c1486 Signed-off-by: Ziye Yang Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5767 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris Reviewed-by: Reviewed-by: Shuhei Matsumoto --- lib/nbd/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nbd/nbd.c b/lib/nbd/nbd.c index 195b0b1e9..14ac179bf 100644 --- a/lib/nbd/nbd.c +++ b/lib/nbd/nbd.c @@ -439,7 +439,7 @@ nbd_socket_rw(int fd, void *buf, size_t length, bool read_op) if (rc == 0) { return -EIO; } else if (rc == -1) { - if (errno != EAGAIN && errno != EWOULDBLOCK) { + if (errno != EAGAIN) { return -errno; } return 0;