ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

posix: set fd to -1 after close(fd) in posix_sock_create()

Browse Source 
In posix_sock_create(), we loops through all the addresses available.
If something is wrong, we should close(fd) and set fd to -1, and
try the next address. Only, when one fd satisfies all conditions,
we will break the loop with the useful fd.

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Change-Id: Icbfc10246c92b95cacd6eb058e6e46cf8924fc4c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8310
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Zhiqiang Liu 2021-06-13 21:10:19 +08:00 committed by Tomasz Zawadzki
parent aafc440e9c
commit b4226d6f99
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
module/sock/posix/posix.c
View File

@ -499,12 +499,14 @@ retry:
rc = setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof val); rc = setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof val);
if (rc != 0) { if (rc != 0) {
close(fd); close(fd);
fd = -1;
/* error */ /* error */
continue; continue;
} }
rc = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof val); rc = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof val);
if (rc != 0) { if (rc != 0) {
close(fd); close(fd);
fd = -1;
/* error */ /* error */
continue; continue;
} }
@ -514,6 +516,7 @@ retry:
rc = setsockopt(fd, SOL_SOCKET, SO_PRIORITY, &opts->priority, sizeof val); rc = setsockopt(fd, SOL_SOCKET, SO_PRIORITY, &opts->priority, sizeof val);
if (rc != 0) { if (rc != 0) {
close(fd); close(fd);
fd = -1;
/* error */ /* error */
continue; continue;
} }
@ -524,6 +527,7 @@ retry:
rc = setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &val, sizeof val); rc = setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &val, sizeof val);
if (rc != 0) { if (rc != 0) {
close(fd); close(fd);
fd = -1;
/* error */ /* error */
continue; continue;
} }