ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iscsi: unregister login_timer when destroying connection

Browse Source 
If a connection is established and we receive a bad
PDU before successful login, the login_timer would not
get unregistered.  So ensure the login_timer is always
unregistered in _iscsi_conn_destruct().

Found with Calsoft tests during new spdk_thread_exit()
assertion testing.  Lack of unregistration would result
in its associated spdk_thread being unable to exit
cleanly due to the unexpired timer.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I79d427512f7829ad76bf89155e0e14c7bce3a7d7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15499
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Jim Harris 2022-11-17 02:52:16 +00:00 committed by Tomasz Zawadzki
parent 090b8af12b
commit b35aceb8cf
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/iscsi/conn.c
View File

@ -612,6 +612,7 @@ _iscsi_conn_destruct(struct spdk_iscsi_conn *conn)
iscsi_clear_all_transfer_task(conn, NULL, NULL);
spdk_poller_unregister(&conn->logout_request_timer);
spdk_poller_unregister(&conn->logout_timer);
spdk_poller_unregister(&conn->login_timer);
rc = iscsi_conn_free_tasks(conn);
if (rc < 0) {