From b28aa25e61a28d9b6fc765bfde68dcccd2dec779 Mon Sep 17 00:00:00 2001 From: paul luse Date: Tue, 3 Sep 2019 21:31:02 -0400 Subject: [PATCH] ut/compress: remove extra success test case By moving the success test case to the end we avoid the scan-build issue however the last test case was already testing success so just udpated the comment and free the memory at the end. Fixes issue #933 Change-Id: I0ca81f240d3af32c414b0c886fda5b14ba37e490 Signed-off-by: paul luse Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/467302 Reviewed-by: yidong0635 Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Shuhei Matsumoto Tested-by: SPDK CI Jenkins --- test/unit/lib/bdev/compress.c/compress_ut.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/test/unit/lib/bdev/compress.c/compress_ut.c b/test/unit/lib/bdev/compress.c/compress_ut.c index 4bf33efc7..1b8b69b56 100644 --- a/test/unit/lib/bdev/compress.c/compress_ut.c +++ b/test/unit/lib/bdev/compress.c/compress_ut.c @@ -782,12 +782,6 @@ test_initdrivers(void) /* This is not an error condition, we already have one */ CU_ASSERT(rc == 0); - /* success */ - MOCK_SET(rte_vdev_init, 0); - rc = vbdev_init_compress_drivers(); - CU_ASSERT(rc == 0); - spdk_mempool_free((struct spdk_mempool *)g_mbuf_mp); - /* error */ MOCK_SET(rte_vdev_init, -2); rc = vbdev_init_compress_drivers(); @@ -848,11 +842,11 @@ test_initdrivers(void) rc = vbdev_init_compress_drivers(); CU_ASSERT(rc == -2); - /* rte_compressdev_private_xform_create()succeeds */ - ut_rte_compressdev_start = 0; + /* success */ ut_rte_compressdev_private_xform_create = 0; rc = vbdev_init_compress_drivers(); CU_ASSERT(rc == 0); + spdk_mempool_free((struct spdk_mempool *)g_mbuf_mp); } static void