ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: clean up test_nvme_ctrlr_fail

Browse Source 
Replace unnecessary allocation with a stack variable.

Clears up a potential NULL pointer dereference indicated by scan-build.

Change-Id: I81a7591729b0f1630bab9ce378716bd2369d6b85
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2015-09-22 16:14:57 -07:00
parent 84cfc97fdf
commit b177c56881
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/lib/nvme/unit/nvme_ctrlr_c/nvme_ctrlr_ut.c
View File

@ -159,22 +159,14 @@ nvme_allocate_request(void *payload, uint32_t payload_size,
} }
void void
test_nvme_ctrlr_fail() test_nvme_ctrlr_fail(void)
{ {
struct nvme_controller *ctrlr = NULL; struct nvme_controller ctrlr = {};
struct nvme_qpair qpair = {};
uint64_t phys_addr = 0;
ctrlr = nvme_malloc("nvme_controller", sizeof(struct nvme_controller), ctrlr.num_io_queues = 0;
64, &phys_addr); nvme_ctrlr_fail(&ctrlr);
CU_ASSERT(ctrlr != NULL);
ctrlr->num_io_queues = 0; CU_ASSERT(ctrlr.is_failed == true);
ctrlr->adminq = qpair;
nvme_ctrlr_fail(ctrlr);
CU_ASSERT(ctrlr->is_failed == true);
nvme_free(ctrlr);
} }
int main(int argc, char **argv) int main(int argc, char **argv)