ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdevperf: clean up output

Browse Source 
We can make the output a bit more precise by putting
the Core Mask on the same line as the Thread Name.

Let's also use "Job Name" instead of "Thread Name"
since that more closely matches the user's intent.
We use a thread internally for each job, but user
specifies workloads in terms of jobs, not threads.

Finally let's get the Total values aligned
with the per-job values again - this seems to have
broken as part of commit d80b4f4.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I04fcd294b8f88374b11e09350aabf84beb2ae60e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6328
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Jim Harris 2021-02-08 21:23:40 +00:00 committed by Tomasz Zawadzki
parent 933868afe5
commit b0c978893c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/bdev/bdevperf/bdevperf.c
View File

@ -226,8 +226,8 @@ performance_dump_job(struct bdevperf_aggregate_stats *stats, struct bdevperf_job
{
double io_per_second, mb_per_second, failed_per_second, timeout_per_second;
printf("\r Thread name: %s\n", spdk_thread_get_name(job->thread));
printf("\t Core Mask: 0x%s\n", spdk_cpuset_fmt(spdk_thread_get_cpumask(job->thread)));
printf("\r Job: %s (Core Mask 0x%s)\n", spdk_thread_get_name(job->thread),
spdk_cpuset_fmt(spdk_thread_get_cpumask(job->thread)));
if (job->verify) {
printf("\t Verification LBA range: start 0x%" PRIx64 " length 0x%" PRIx64 "\n",
job->ios_base, job->size_in_ios);
@ -410,11 +410,11 @@ bdevperf_test_done(void *ctx)
free(job);
}
printf("\r =====================================================\n");
printf("\r %-20s: %10.2f IOPS %10.2f MiB/s\n",
printf("\r =============================================================\n");
printf("\r %-28s: %10.2f IOPS %10.2f MiB/s\n",
"Total", g_stats.total_io_per_second, g_stats.total_mb_per_second);
if (g_stats.total_failed_per_second != 0 || g_stats.total_timeout_per_second != 0) {
printf("\r %-20s: %10.2f Fail/s %8.2f TO/s\n",
printf("\r %-28s: %10.2f Fail/s %8.2f TO/s\n",
"", g_stats.total_failed_per_second, g_stats.total_timeout_per_second);
}
fflush(stdout);