ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme/pcie: rename trace object to NVME_PCIE_REQ

Browse Source 
We were using "TR" for "tracker" previously, but
we are tracing the nvme_requests, not nvme_trackers,
so use the right names for the trace object to avoid
confusion.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Ia3886d74b162138c2cdbe0017224d9494f74966c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13990
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Jim Harris 2022-08-10 20:59:18 +00:00 committed by Tomasz Zawadzki
parent 97661e86b7
commit b0396da090
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/spdk_internal/trace_defs.h
View File

@ -18,7 +18,7 @@
/* Object definitions */ /* Object definitions */
#define OBJECT_ISCSI_PDU 0x1 #define OBJECT_ISCSI_PDU 0x1
#define OBJECT_BDEV_IO 0x2 #define OBJECT_BDEV_IO 0x2
#define OBJECT_NVME_PCIE_TR 0x3 #define OBJECT_NVME_PCIE_REQ 0x3
#define OBJECT_SCSI_TASK 0x10 #define OBJECT_SCSI_TASK 0x10
#define OBJECT_NVMF_RDMA_IO 0x40 #define OBJECT_NVMF_RDMA_IO 0x40
#define OBJECT_NVMF_TCP_IO 0x80 #define OBJECT_NVMF_TCP_IO 0x80

6
lib/nvme/nvme_pcie_common.c
View File

@ -1817,7 +1817,7 @@ SPDK_TRACE_REGISTER_FN(nvme_pcie, "nvme_pcie", TRACE_GROUP_NVME_PCIE)
struct spdk_trace_tpoint_opts opts[] = { struct spdk_trace_tpoint_opts opts[] = {
{ {
"NVME_PCIE_SUBMIT", TRACE_NVME_PCIE_SUBMIT, "NVME_PCIE_SUBMIT", TRACE_NVME_PCIE_SUBMIT,
OWNER_NVME_PCIE_QP, OBJECT_NVME_PCIE_TR, 1, OWNER_NVME_PCIE_QP, OBJECT_NVME_PCIE_REQ, 1,
{ { "cid", SPDK_TRACE_ARG_TYPE_INT, 4 }, { { "cid", SPDK_TRACE_ARG_TYPE_INT, 4 },
{ "opc", SPDK_TRACE_ARG_TYPE_INT, 4 }, { "opc", SPDK_TRACE_ARG_TYPE_INT, 4 },
{ "dw10", SPDK_TRACE_ARG_TYPE_PTR, 4 }, { "dw10", SPDK_TRACE_ARG_TYPE_PTR, 4 },
@ -1827,14 +1827,14 @@ SPDK_TRACE_REGISTER_FN(nvme_pcie, "nvme_pcie", TRACE_GROUP_NVME_PCIE)
}, },
{ {
"NVME_PCIE_COMPLETE", TRACE_NVME_PCIE_COMPLETE, "NVME_PCIE_COMPLETE", TRACE_NVME_PCIE_COMPLETE,
OWNER_NVME_PCIE_QP, OBJECT_NVME_PCIE_TR, 0, OWNER_NVME_PCIE_QP, OBJECT_NVME_PCIE_REQ, 0,
{ { "cid", SPDK_TRACE_ARG_TYPE_INT, 4 }, { { "cid", SPDK_TRACE_ARG_TYPE_INT, 4 },
{ "cpl", SPDK_TRACE_ARG_TYPE_PTR, 4 } { "cpl", SPDK_TRACE_ARG_TYPE_PTR, 4 }
} }
}, },
}; };
spdk_trace_register_object(OBJECT_NVME_PCIE_TR, 'p'); spdk_trace_register_object(OBJECT_NVME_PCIE_REQ, 'p');
spdk_trace_register_owner(OWNER_NVME_PCIE_QP, 'q'); spdk_trace_register_owner(OWNER_NVME_PCIE_QP, 'q');
spdk_trace_register_description_ext(opts, SPDK_COUNTOF(opts)); spdk_trace_register_description_ext(opts, SPDK_COUNTOF(opts));
} }