From af4fa14891f4eccb75a22a470248e2b8593de985 Mon Sep 17 00:00:00 2001 From: WANGHAILIANG Date: Fri, 21 Aug 2020 15:31:00 +0800 Subject: [PATCH] module/bdev_raid: remove an ERROR log which occurs every times This ERROR log is: bdev_raid_rpc.c: 276:rpc_bdev_raid_create: *ERROR*: the rpc param strip_size is deprecated. raid_bdev_write_config_json() generates a bdev.json: { "method": "bdev_raid_create", "params": { "name": "raid0", "strip_size": 64, "raid_level": "raid0", "base_bdevs": [ "Malloc4", "Malloc5" ] } }, rpc_bdev_raid_create() will check this req.strip_size, it always print this ERROR log: else if (req.strip_size > 0 && req.strip_size_kb == 0) { SPDK_ERRLOG("the rpc param strip_size is deprecated.\n"); So I replace "strip_size" with "strip_size_kb" here. Change-Id: Ic9570c88dd336a755ccd53690962eddbaac22e1b Signed-off-by: WANGHAILIANG Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3885 Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Community-CI: Mellanox Build Bot --- module/bdev/raid/bdev_raid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/bdev/raid/bdev_raid.c b/module/bdev/raid/bdev_raid.c index 10da1a799..f3fdfb182 100644 --- a/module/bdev/raid/bdev_raid.c +++ b/module/bdev/raid/bdev_raid.c @@ -665,7 +665,7 @@ raid_bdev_write_config_json(struct spdk_bdev *bdev, struct spdk_json_write_ctx * spdk_json_write_named_object_begin(w, "params"); spdk_json_write_named_string(w, "name", bdev->name); - spdk_json_write_named_uint32(w, "strip_size", raid_bdev->strip_size_kb); + spdk_json_write_named_uint32(w, "strip_size_kb", raid_bdev->strip_size_kb); spdk_json_write_named_string(w, "raid_level", raid_bdev_level_to_str(raid_bdev->level)); spdk_json_write_named_array_begin(w, "base_bdevs");