From aef71e29a02f9526d259bf27fee5e280feab0f3d Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Tue, 22 Mar 2022 14:25:26 -0700 Subject: [PATCH] spdk_dd: Use IORING_SETUP_SQPOLL mode This has better performance than interrupt mode, so it is a better default. Change-Id: Ia2e13058b9b36874cd402f97ef57db77192f596a Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12021 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki --- app/spdk_dd/spdk_dd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/spdk_dd/spdk_dd.c b/app/spdk_dd/spdk_dd.c index d3e6ea1ef..981b8ddea 100644 --- a/app/spdk_dd/spdk_dd.c +++ b/app/spdk_dd/spdk_dd.c @@ -857,7 +857,12 @@ dd_run(void *arg1) #ifdef SPDK_CONFIG_URING if (g_opts.aio == false) { g_job.u.uring.poller = spdk_poller_register(dd_uring_poll, NULL, 0); - io_uring_queue_init(g_opts.queue_depth * 2, &g_job.u.uring.ring, 0); + rc = io_uring_queue_init(g_opts.queue_depth * 2, &g_job.u.uring.ring, IORING_SETUP_SQPOLL); + if (rc) { + SPDK_ERRLOG("Failed to create io_uring: %d (%s)\n", rc, spdk_strerror(-rc)); + dd_exit(rc); + return; + } g_job.u.uring.active = true; } else #endif