From aedbb3b81aabe3744b47c21876b9c5c62ddabf08 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Mon, 9 Apr 2018 16:08:55 -0700 Subject: [PATCH] nvme: Rmove all uses of strncpy strncpy is going to be added to the list of banned functions because it does not guarantee strings are null terminated. Change-Id: Ic18623c281cca7c3d87732bc7677b284d57685c8 Signed-off-by: Ben Walker Reviewed-on: https://review.gerrithub.io/407023 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Jim Harris --- lib/nvme/nvme_rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/nvme/nvme_rdma.c b/lib/nvme/nvme_rdma.c index 0adf8d9ff..9678305de 100644 --- a/lib/nvme/nvme_rdma.c +++ b/lib/nvme/nvme_rdma.c @@ -638,8 +638,8 @@ nvme_rdma_qpair_fabric_connect(struct nvme_rdma_qpair *rqpair) SPDK_STATIC_ASSERT(sizeof(nvmf_data->hostid) == sizeof(ctrlr->opts.extended_host_id), "host ID size mismatch"); memcpy(nvmf_data->hostid, ctrlr->opts.extended_host_id, sizeof(nvmf_data->hostid)); - strncpy((char *)nvmf_data->hostnqn, ctrlr->opts.hostnqn, sizeof(nvmf_data->hostnqn)); - strncpy((char *)nvmf_data->subnqn, ctrlr->trid.subnqn, sizeof(nvmf_data->subnqn)); + snprintf(nvmf_data->hostnqn, sizeof(nvmf_data->hostnqn), "%s", ctrlr->opts.hostnqn); + snprintf(nvmf_data->subnqn, sizeof(nvmf_data->subnqn), "%s", ctrlr->trid.subnqn); rc = spdk_nvme_ctrlr_cmd_io_raw(ctrlr, &rqpair->qpair, (struct spdk_nvme_cmd *)&cmd,