From aeb693ca07082f1988274b481130473c17ae4779 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Fri, 4 Sep 2020 11:27:37 +0900 Subject: [PATCH] bdev/gpt: Change ERRLOG to DEBUGLOG to show interleaved metadata is not supported It is a good enhancement for the GPT vbdev module to support interleaved metadata but interleaved metadata is not critical and the priority is low. However the following error log is always collected when there is any bdev with interleaved metadata. vbdev_gpt.c: 552:vbdev_gpt_examine: *ERROR*: GPT module does not support block size 4224 for bdev Null0 This does not cause any failure but confuses user. Hence, change the corresponding print from ERRLOG to DEBUGLOG. Signed-off-by: Shuhei Matsumoto Change-Id: Id58507cbdc830d2b139fb34faa29e08d73c16141 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4058 Tested-by: SPDK CI Jenkins Reviewed-by: Ziye Yang Reviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Community-CI: Broadcom CI --- module/bdev/gpt/vbdev_gpt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/module/bdev/gpt/vbdev_gpt.c b/module/bdev/gpt/vbdev_gpt.c index 5232444fb..3d6083058 100644 --- a/module/bdev/gpt/vbdev_gpt.c +++ b/module/bdev/gpt/vbdev_gpt.c @@ -549,8 +549,9 @@ vbdev_gpt_examine(struct spdk_bdev *bdev) } if (spdk_bdev_get_block_size(bdev) % 512 != 0) { - SPDK_ERRLOG("GPT module does not support block size %" PRIu32 " for bdev %s\n", - spdk_bdev_get_block_size(bdev), spdk_bdev_get_name(bdev)); + SPDK_DEBUGLOG(SPDK_LOG_VBDEV_GPT, + "GPT module does not support block size %" PRIu32 " for bdev %s\n", + spdk_bdev_get_block_size(bdev), spdk_bdev_get_name(bdev)); spdk_bdev_module_examine_done(&gpt_if); return; }