ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf: remove request exec backdoor

Browse Source 
It was introduced for the purpose of executing fabric cmds when
subsystem and qpairs are not active. It was rather workaround than
solution for transport type like vfio-user. spdk_nvmf_request_exec
is a preferred way of passing request obj into nvmf layer.

Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I4f989de27bfd494c744017599909c2e200f0f233
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4180
Community-CI: Broadcom CI
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
Jacek Kalwas 2020-09-13 01:59:43 +02:00 committed by Tomasz Zawadzki
parent ce7eee9861
commit ae207216fb
3 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/spdk/nvmf_transport.h
View File

@ -410,7 +410,6 @@ int spdk_nvmf_request_get_buffers_multi(struct spdk_nvmf_request *req,
bool spdk_nvmf_request_get_dif_ctx(struct spdk_nvmf_request *req, struct spdk_dif_ctx *dif_ctx);
void spdk_nvmf_request_exec(struct spdk_nvmf_request *req);
void spdk_nvmf_request_exec_fabrics(struct spdk_nvmf_request *req);
int spdk_nvmf_request_free(struct spdk_nvmf_request *req);
int spdk_nvmf_request_complete(struct spdk_nvmf_request *req);

18
lib/nvmf/ctrlr.c
View File

@ -3335,24 +3335,6 @@ _nvmf_request_exec(struct spdk_nvmf_request *req,
}
}
void
spdk_nvmf_request_exec_fabrics(struct spdk_nvmf_request *req)
{
struct spdk_nvmf_qpair *qpair = req->qpair;
struct spdk_nvmf_subsystem_poll_group *sgroup = NULL;
assert(req->cmd->nvmf_cmd.opcode == SPDK_NVME_OPC_FABRIC);
if (qpair->ctrlr) {
sgroup = &qpair->group->sgroups[qpair->ctrlr->subsys->id];
assert(sgroup != NULL);
} else {
sgroup = nvmf_subsystem_pg_from_connect_cmd(req);
}
_nvmf_request_exec(req, sgroup);
}
void
spdk_nvmf_request_exec(struct spdk_nvmf_request *req)
{

1
lib/nvmf/spdk_nvmf.map
View File

@ -107,7 +107,6 @@
spdk_nvmf_request_get_buffers_multi;
spdk_nvmf_request_get_dif_ctx;
spdk_nvmf_request_exec;
spdk_nvmf_request_exec_fabrics;
spdk_nvmf_request_free;
spdk_nvmf_request_complete;
spdk_nvmf_ctrlr_get_subsystem;