From ae161cdec676a1a2d307461d1aa4304b7cb182da Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Tue, 3 Mar 2020 12:19:35 -0700 Subject: [PATCH] nvme/rdma: make sure we free resources in error path. Not sure how we missed this. Signed-off-by: Seth Howell Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1122 (master) (cherry picked from commit 2248e52150e401b779bcaa689812fb10f8cceb2c) Change-Id: If920cb3a7708c33032e1da28c564d4c28ddafdf4 Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2608 Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- lib/nvme/nvme_rdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/nvme/nvme_rdma.c b/lib/nvme/nvme_rdma.c index cd70d0f9c..6ca02639b 100644 --- a/lib/nvme/nvme_rdma.c +++ b/lib/nvme/nvme_rdma.c @@ -1571,6 +1571,7 @@ nvme_rdma_ctrlr_create_qpair(struct spdk_nvme_ctrlr *ctrlr, SPDK_DEBUGLOG(SPDK_LOG_NVME, "rc =%d\n", rc); if (rc) { SPDK_ERRLOG("Unable to allocate rqpair RDMA requests\n"); + free(rqpair); return NULL; } SPDK_DEBUGLOG(SPDK_LOG_NVME, "RDMA requests allocated\n"); @@ -1579,6 +1580,8 @@ nvme_rdma_ctrlr_create_qpair(struct spdk_nvme_ctrlr *ctrlr, SPDK_DEBUGLOG(SPDK_LOG_NVME, "rc =%d\n", rc); if (rc < 0) { SPDK_ERRLOG("Unable to allocate rqpair RDMA responses\n"); + nvme_rdma_free_reqs(rqpair); + free(rqpair); return NULL; } SPDK_DEBUGLOG(SPDK_LOG_NVME, "RDMA responses allocated\n");