From ad6ece23d011330f1c6df871a56e4734ecc03d97 Mon Sep 17 00:00:00 2001 From: Mike Gerdts Date: Tue, 11 Oct 2022 09:55:42 -0500 Subject: [PATCH] blob: blob_open_opts_copy macro uses wrong type The FIELD_OK macro in blob_open_opts_copy() should consider offsets in struct spdk_blob_open_opts, not struct spdk_blob_opts. Signed-off-by: Mike Gerdts Change-Id: I62e22acbe7dfb994453a379c92f78b7e9bc7fc13 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14962 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki --- lib/blob/blobstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/blob/blobstore.c b/lib/blob/blobstore.c index c2730c3cf..9e43d0761 100644 --- a/lib/blob/blobstore.c +++ b/lib/blob/blobstore.c @@ -7295,7 +7295,7 @@ static inline void blob_open_opts_copy(const struct spdk_blob_open_opts *src, struct spdk_blob_open_opts *dst) { #define FIELD_OK(field) \ - offsetof(struct spdk_blob_opts, field) + sizeof(src->field) <= src->opts_size + offsetof(struct spdk_blob_open_opts, field) + sizeof(src->field) <= src->opts_size #define SET_FIELD(field) \ if (FIELD_OK(field)) { \