From ad272579b90acb203e393cd504e17c0f63577163 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Mon, 28 Jan 2019 14:59:42 -0700 Subject: [PATCH] nvmf: Clarify wording of buf cache size parameter I think this wording is slightly more clear. Change-Id: I9fc500b8b87c0520bdf96e6c5db490bb98121da3 Signed-off-by: Ben Walker Reviewed-on: https://review.gerrithub.io/c/442435 Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- doc/jsonrpc.md | 2 +- scripts/rpc.py | 2 +- scripts/rpc/nvmf.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/jsonrpc.md b/doc/jsonrpc.md index da0a96bb3..0482f0636 100644 --- a/doc/jsonrpc.md +++ b/doc/jsonrpc.md @@ -3488,7 +3488,7 @@ max_io_size | Optional | number | Max I/O size (bytes) io_unit_size | Optional | number | I/O unit size (bytes) max_aq_depth | Optional | number | Max number of admin cmds per AQ num_shared_buffers | Optional | number | The number of pooled data buffers available to the transport -buf_cache_size | Optional | number | The number of shared buffers to cache per poll group +buf_cache_size | Optional | number | The number of shared buffers to reserve for each poll group ### Example: diff --git a/scripts/rpc.py b/scripts/rpc.py index 9c37a5502..f3f540e93 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -1375,7 +1375,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse p.add_argument('-u', '--io-unit-size', help='I/O unit size (bytes)', type=int) p.add_argument('-a', '--max-aq-depth', help='Max number of admin cmds per AQ', type=int) p.add_argument('-n', '--num-shared-buffers', help='The number of pooled data buffers available to the transport', type=int) - p.add_argument('-b', '--buf-cache-size', help='The number of shared buffers to cache per poll group', type=int) + p.add_argument('-b', '--buf-cache-size', help='The number of shared buffers to reserve for each poll group', type=int) p.set_defaults(func=nvmf_create_transport) def get_nvmf_transports(args): diff --git a/scripts/rpc/nvmf.py b/scripts/rpc/nvmf.py index ca121bd50..3f9559de4 100644 --- a/scripts/rpc/nvmf.py +++ b/scripts/rpc/nvmf.py @@ -56,7 +56,7 @@ def nvmf_create_transport(client, io_unit_size: I/O unit size in bytes (optional) max_aq_depth: Max size admin quque per controller (optional) num_shared_buffers: The number of pooled data buffers available to the transport (optional) - buf_cache_size: The number of shared buffers to cache per poll group (optional) + buf_cache_size: The number of shared buffers to reserve for each poll group(optional) Returns: True or False