From ad063db506ba34b46c4d9e1eecc07ab08aa2e969 Mon Sep 17 00:00:00 2001
From: Daniel Verkamp <daniel.verkamp@intel.com>
Date: Thu, 2 Feb 2017 09:44:26 -0700
Subject: [PATCH] nvmf: apply const to several char * arguments

These strings are not modified by the functions they are passed to, so
they can be const char *.

Change-Id: I11532f232990a305d706c14aac1b0f8f93b8f576
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
---
 app/nvmf_tgt/conf.c                    | 4 ++--
 include/spdk/nvmf.h                    | 4 ++--
 lib/nvmf/nvmf.c                        | 2 +-
 lib/nvmf/nvmf_internal.h               | 4 ++--
 lib/nvmf/subsystem.c                   | 4 ++--
 test/lib/nvmf/subsystem/subsystem_ut.c | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/nvmf_tgt/conf.c b/app/nvmf_tgt/conf.c
index d3f8fbce2..a0ddf4f1f 100644
--- a/app/nvmf_tgt/conf.c
+++ b/app/nvmf_tgt/conf.c
@@ -87,7 +87,7 @@ struct spdk_nvmf_tgt_conf g_spdk_nvmf_tgt_conf;
 static int32_t g_last_rpc_lcore = -1;
 
 static int
-spdk_get_numa_node_value(char *path)
+spdk_get_numa_node_value(const char *path)
 {
 	FILE *fd;
 	int numa_node = -1;
@@ -107,7 +107,7 @@ spdk_get_numa_node_value(char *path)
 }
 
 static int
-spdk_get_ifaddr_numa_node(char *if_addr)
+spdk_get_ifaddr_numa_node(const char *if_addr)
 {
 	int ret;
 	struct ifaddrs *ifaddrs, *ifa;
diff --git a/include/spdk/nvmf.h b/include/spdk/nvmf.h
index b67572fb6..4784f7d93 100644
--- a/include/spdk/nvmf.h
+++ b/include/spdk/nvmf.h
@@ -174,11 +174,11 @@ bool spdk_nvmf_subsystem_host_allowed(struct spdk_nvmf_subsystem *subsystem, con
 
 int
 spdk_nvmf_subsystem_add_listener(struct spdk_nvmf_subsystem *subsystem,
-				 char *trname, char *traddr, char *trsvcid);
+				 const char *trname, const char *traddr, const char *trsvcid);
 
 int
 spdk_nvmf_subsystem_add_host(struct spdk_nvmf_subsystem *subsystem,
-			     char *host_nqn);
+			     const char *host_nqn);
 
 int
 nvmf_subsystem_add_ctrlr(struct spdk_nvmf_subsystem *subsystem,
diff --git a/lib/nvmf/nvmf.c b/lib/nvmf/nvmf.c
index 511505cbc..3d43200bf 100644
--- a/lib/nvmf/nvmf.c
+++ b/lib/nvmf/nvmf.c
@@ -82,7 +82,7 @@ spdk_nvmf_tgt_fini(void)
 }
 
 struct spdk_nvmf_listen_addr *
-spdk_nvmf_listen_addr_create(char *trname, char *traddr, char *trsvcid)
+spdk_nvmf_listen_addr_create(const char *trname, const char *traddr, const char *trsvcid)
 {
 	struct spdk_nvmf_listen_addr *listen_addr;
 	const struct spdk_nvmf_transport *transport;
diff --git a/lib/nvmf/nvmf_internal.h b/lib/nvmf/nvmf_internal.h
index fd6866cc9..56824d740 100644
--- a/lib/nvmf/nvmf_internal.h
+++ b/lib/nvmf/nvmf_internal.h
@@ -65,8 +65,8 @@ nvmf_u32log2(uint32_t x)
 
 extern struct spdk_nvmf_tgt g_nvmf_tgt;
 
-struct spdk_nvmf_listen_addr *spdk_nvmf_listen_addr_create(char *trname, char *traddr,
-		char *trsvcid);
+struct spdk_nvmf_listen_addr *spdk_nvmf_listen_addr_create(const char *trname, const char *traddr,
+		const char *trsvcid);
 void spdk_nvmf_listen_addr_destroy(struct spdk_nvmf_listen_addr *addr);
 
 #define OBJECT_NVMF_IO				0x30
diff --git a/lib/nvmf/subsystem.c b/lib/nvmf/subsystem.c
index 3e43d1d60..c295d0d33 100644
--- a/lib/nvmf/subsystem.c
+++ b/lib/nvmf/subsystem.c
@@ -252,7 +252,7 @@ spdk_nvmf_delete_subsystem(struct spdk_nvmf_subsystem *subsystem)
 
 int
 spdk_nvmf_subsystem_add_listener(struct spdk_nvmf_subsystem *subsystem,
-				 char *trname, char *traddr, char *trsvcid)
+				 const char *trname, const char *traddr, const char *trsvcid)
 {
 	struct spdk_nvmf_listen_addr *listen_addr;
 	const struct spdk_nvmf_transport *transport;
@@ -282,7 +282,7 @@ spdk_nvmf_subsystem_add_listener(struct spdk_nvmf_subsystem *subsystem,
 }
 
 int
-spdk_nvmf_subsystem_add_host(struct spdk_nvmf_subsystem *subsystem, char *host_nqn)
+spdk_nvmf_subsystem_add_host(struct spdk_nvmf_subsystem *subsystem, const char *host_nqn)
 {
 	struct spdk_nvmf_host *host;
 
diff --git a/test/lib/nvmf/subsystem/subsystem_ut.c b/test/lib/nvmf/subsystem/subsystem_ut.c
index be81cc3a1..d3e515d1e 100644
--- a/test/lib/nvmf/subsystem/subsystem_ut.c
+++ b/test/lib/nvmf/subsystem/subsystem_ut.c
@@ -49,7 +49,7 @@ SPDK_LOG_REGISTER_TRACE_FLAG("nvmf", SPDK_TRACE_NVMF)
 struct spdk_nvmf_tgt g_nvmf_tgt;
 
 struct spdk_nvmf_listen_addr *
-spdk_nvmf_listen_addr_create(char *trname, char *traddr, char *trsvcid)
+spdk_nvmf_listen_addr_create(const char *trname, const char *traddr, const char *trsvcid)
 {
 	struct spdk_nvmf_listen_addr *listen_addr;